Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal that inherits from a controller scope, it will also inherit the above content's has-tabs! #924

Closed
cutzenfriend opened this issue Mar 27, 2014 · 3 comments
Milestone

Comments

@cutzenfriend
Copy link

If you have a modal that inherits from a controller scope, it will also inherit the above content's has-tabs.

0b2db8846f4b3791

Possible fix:

CSS:

div.modal-backdrop.active ion-content.has-tabs {
    bottom: 0px;
}
@ajoslin ajoslin self-assigned this Mar 27, 2014
@ajoslin ajoslin added this to the 1.0.0-beta.2 milestone Mar 27, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Mar 27, 2014

Fixed in nightly! Thanks for the good report.

@ewang
Copy link

ewang commented Apr 18, 2014

@ajoslin Still seem to have this problem in the nightly-1717 build.

I'm passing in {scope: $scope} into the ionicModal.fromTemplateUrl() call:

$ionicModal.fromTemplateUrl('templates/modal.html', {
        scope: $scope,
        animation: 'slide-in-up'
    }).then(function(modal) {
        $scope.modal = modal;
    });

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants