Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDS_VERSION not handled correctly/automatically #47

Closed
muehlke opened this issue Nov 13, 2024 · 3 comments
Closed

UDS_VERSION not handled correctly/automatically #47

muehlke opened this issue Nov 13, 2024 · 3 comments

Comments

@muehlke
Copy link
Contributor

muehlke commented Nov 13, 2024

@driftregion I was just wondering how the versioning mechanism has been decided for this repo. The src/version.h points at 0.7.0 and the latest release at v0.7.1. On the other side, I don't see some logic for incrementing the versions on the .github/workflows/release.yml. Is this maybe planned for the future? Otherwise, before every official release one would have to add the new version to src/version.h before merging, which can be easily forgotten.

Best regards ✌️

@driftregion
Copy link
Owner

Great points, thanks! I would like to do a release checklist similar to https://sqlite.org/src/ext/checklist/3270000/index , but haven't gotten around to it yet. Here's a rough draft:

Checklist:

  • increment version in src/version.h
  • git tag with release version (the current implementation of .github/workflows/release.yml grabs the release triple from the git tag)

@driftregion
Copy link
Owner

Release checklist updated in README.md

@muehlke
Copy link
Contributor Author

muehlke commented Jan 24, 2025

Great job! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants