Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sets for laravel upgrade rules #38

Closed
hirenkeraliya opened this issue Mar 25, 2022 · 6 comments · Fixed by #49
Closed

Create sets for laravel upgrade rules #38

hirenkeraliya opened this issue Mar 25, 2022 · 6 comments · Fixed by #49

Comments

@hirenkeraliya
Copy link
Contributor

I check all the rules and upgrade for the laravel 7 to 8 and 8 to 9.
I got the rules can we make a set for this laravel upgrade?
if you agree then I will do that.

@samsonasik
Copy link
Collaborator

The set seems exists until laravel 8

https://github.com/rectorphp/rector-laravel/blob/6bee4284d50e84eb5d027ff266801b2a1c903a33/src/Set/LaravelLevelSetList.php#L64

feel free to create new set list PR until laravel 9

@TomasVotruba
Copy link
Collaborator

Hi, that would be very useful!

Please go for it 👍

@hirenkeraliya
Copy link
Contributor Author

hirenkeraliya commented Mar 26, 2022

@samsonasik oh it's great. do we have documentation for it anywhere? if not then we also need to do this first.

@samsonasik
Copy link
Collaborator

@hirenkeraliya there is documentation for use set https://github.com/rectorphp/rector-laravel#use-sets , feel free to create documentation improvement PR.

@hirenkeraliya
Copy link
Contributor Author

hirenkeraliya commented May 14, 2022

@samsonasik

Initially, I added a new rector class at that time I did it using the package development blog post.

But, I tried it today it's not working. And, also the rector configuration is changed. So, how can we debug when we want to print the object like $methodCall?

Can you able to help me with this?

@samsonasik
Copy link
Collaborator

You can debug with print_node($node) or dump_node($node),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants