Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watermark): fix invalid plugin configuration #4389

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Dec 30, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested a review from ybzky as a code owner December 30, 2024 09:55
Copy link

github-actions bot commented Dec 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  8d6d444
info  For more information, see full report

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.37%. Comparing base (e909093) to head (8d6d444).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/watermark/src/plugin.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4389      +/-   ##
==========================================
- Coverage   33.37%   33.37%   -0.01%     
==========================================
  Files        2529     2529              
  Lines      130404   130407       +3     
  Branches    29103    29104       +1     
==========================================
  Hits        43526    43526              
- Misses      86878    86881       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit e3930bb into dev Dec 30, 2024
9 checks passed
@jikkai jikkai deleted the fix/watermark-options branch December 30, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants