From d2557ba46900a768f71047233d677a53af06e318 Mon Sep 17 00:00:00 2001
From: Sergey Volkov <s.volkov@netris.ru>
Date: Tue, 8 Feb 2022 14:49:17 +0300
Subject: [PATCH] fix(android): commit fragments transaction only once after
 wrapping view being attached to a window

prevent crash when using ti.map inside a ListView

ref TIMOB-28583 fix #13243
---
 .../titanium/view/TiUIFragment.java           | 26 ++++++++++++++-----
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java b/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java
index a108f03afef..e7189380b02 100644
--- a/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java
+++ b/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java
@@ -38,21 +38,30 @@ public TiUIFragment(TiViewProxy proxy, Activity activity)
 			fragment = createFragment();
 		} else {
 			TiCompositeLayout container = new TiCompositeLayout(activity, proxy) {
+				private boolean transactionCommitted = false;
 				@Override
 				public boolean dispatchTouchEvent(MotionEvent ev)
 				{
 					return interceptTouchEvent(ev) || super.dispatchTouchEvent(ev);
 				}
+
+				@Override
+				protected void onAttachedToWindow()
+				{
+					super.onAttachedToWindow();
+					if (!transactionCommitted) {
+						transactionCommitted = true;
+						FragmentManager manager = ((FragmentActivity) getContext()).getSupportFragmentManager();
+						FragmentTransaction transaction = manager.beginTransaction();
+						transaction.runOnCommit(onCommitRunnable);
+						fragment = createFragment();
+						transaction.add(getId(), fragment);
+						transaction.commitAllowingStateLoss();
+					}
+				}
 			};
 			container.setId(View.generateViewId());
 			setNativeView(container);
-
-			FragmentManager manager = ((FragmentActivity) activity).getSupportFragmentManager();
-			FragmentTransaction transaction = manager.beginTransaction();
-			transaction.runOnCommit(onCommitRunnable);
-			fragment = createFragment();
-			transaction.add(container.getId(), fragment);
-			transaction.commitAllowingStateLoss();
 		}
 	}
 
@@ -68,6 +77,9 @@ public void run()
 
 	public void realizeFragmentViews()
 	{
+		if (childrenToRealize == null) {
+			return;
+		}
 		for (TiUIView child : childrenToRealize) {
 			// Draw the views
 			((ViewGroup) getNativeView()).addView(child.getOuterView(), child.getLayoutParams());