Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: searcher plugin change return params #844

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 1, 2021

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • searcher plugin change return params.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Dec 1, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 1, 2021 04:01
@gaius-qi gaius-qi self-assigned this Dec 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #844 (05f186a) into main (eb06464) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   41.11%   41.21%   +0.10%     
==========================================
  Files         102      102              
  Lines        8068     8070       +2     
==========================================
+ Hits         3317     3326       +9     
+ Misses       4341     4331      -10     
- Partials      410      413       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.21% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/searcher/searcher.go 66.66% <100.00%> (+4.84%) ⬆️
client/daemon/peer/peertask_stream_callback.go 62.13% <0.00%> (-1.95%) ⬇️
client/daemon/peer/peertask_base.go 47.27% <0.00%> (+0.60%) ⬆️
client/daemon/peer/peertask_stream.go 55.04% <0.00%> (+1.22%) ⬆️

@gaius-qi gaius-qi merged commit ee68e97 into main Dec 1, 2021
@gaius-qi gaius-qi deleted the feature/searcher-plugin branch December 1, 2021 04:07
gaius-qi added a commit that referenced this pull request Dec 1, 2021
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Dec 1, 2021
* feat: support mutli manager addrs (#844)

Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: support mutli manager addrs (#844)

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants