Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint markdown #779

Merged
merged 9 commits into from
Nov 4, 2021
Merged

chore: lint markdown #779

merged 9 commits into from
Nov 4, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 3, 2021

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • add lint markdown workflow.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi
chore: lint markdown
5b50820 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
feat: remove gci
94701c4 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 3, 2021
@gaius-qi gaius-qi self-assigned this Nov 3, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 3, 2021 06:31
@gaius-qi
feat: lint
75a1f63 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
feat: lint
aa7774d 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #779 (7b71ea9) into main (ed570ba) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   39.67%   39.71%   +0.03%     
==========================================
  Files          94       94              
  Lines        7647     7647              
==========================================
+ Hits         3034     3037       +3     
+ Misses       4218     4215       -3     
  Partials      395      395
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 39.71% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/unit/byte.go 40.24% <0.00%> (ø)
internal/job/job.go 16.41% <0.00%> (ø)
client/dfget/dfget.go 15.32% <0.00%> (ø)
cdn/storedriver/driver.go 16.66% <0.00%> (ø)
client/config/peerhost.go 36.00% <0.00%> (ø)
cdn/rpcserver/rpcserver.go 0.00% <0.00%> (ø)
scheduler/config/config.go 4.70% <0.00%> (ø)
cdn/storedriver/store_mgr.go 60.00% <0.00%> (ø)
manager/searcher/searcher.go 82.05% <0.00%> (ø)
scheduler/supervisor/host.go 56.25% <0.00%> (ø)
... and 16 more

@gaius-qi
feat: markdown lint
3145958 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi requested a review from a team as a code owner November 3, 2021 06:50
@gaius-qi gaius-qi force-pushed the chore/lint-markdown branch 16 times, most recently from f25f9e3 to a543578 Compare November 3, 2021 08:12
@gaius-qi
feat: api
6378f18 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the chore/lint-markdown branch from a543578 to 6378f18 Compare November 3, 2021 08:48
@gaius-qi
feat: readme
036f126 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
feat: README
e69eac2 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the chore/lint-markdown branch from 7b71ea9 to e69eac2 Compare November 4, 2021 02:48
cndoit18
cndoit18 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 077c7e2 into main Nov 4, 2021
@gaius-qi gaius-qi deleted the chore/lint-markdown branch November 4, 2021 10:21
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
chore: add markdown lint (#779)
a6b7c46 
* chore: add markdown lint

Signed-off-by: Gaius <gaius.qi@gmail.com>

* docs: fix markdown lint errors

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
feat: load certs in dfdaemon config (dragonflyoss#779)
feb38d7 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@cndoit18 cndoit18 cndoit18 approved these changes

@zzy987 zzy987 zzy987 approved these changes

@jim3ma jim3ma Awaiting requested review from jim3ma jim3ma is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

Assignees

@gaius-qi gaius-qi

Labels
None yet
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@gaius-qi @codecov-commenter @yxxhero @cndoit18 @zzy987