Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add peer to task failed because InnerBucketMaxLength is small #765

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

244372610
Copy link
Contributor

Signed-off-by: santong weipeng.swp@alibaba-inc.com

Description

add peer to task failed because InnerBucketMaxLength is small

Related Issue

#760

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
@244372610 244372610 requested a review from a team as a code owner October 28, 2021 04:01
@codecov-commenter
Copy link

Codecov Report

Merging #765 (b966600) into main (51b36b5) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   38.36%   38.30%   -0.06%     
==========================================
  Files          91       91              
  Lines        7040     7040              
==========================================
- Hits         2701     2697       -4     
- Misses       3955     3960       +5     
+ Partials      384      383       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.30% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/structure/sortedlist/sorted_list.go 56.31% <ø> (ø)
client/daemon/peer/peertask_stream.go 54.60% <0.00%> (-2.23%) ⬇️
client/daemon/peer/peertask_base.go 34.38% <0.00%> (+0.62%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 373a30d into main Oct 28, 2021
@gaius-qi gaius-qi deleted the feature/fixFreeLoadMaxAddFail branch October 28, 2021 04:17
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
)

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants