Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update kubernetes docs #705

Merged
merged 2 commits into from
Sep 30, 2021
Merged

docs: update kubernetes docs #705

merged 2 commits into from
Sep 30, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Sep 30, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma
docs: update kubernetes docs
3e2876e 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner September 30, 2021 10:08
@jim3ma
docs: update kubernetes zh docs
1b07259 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma force-pushed the feature/update-k8s-docs branch from d639e29 to 1b07259 Compare September 30, 2021 10:13
gaius-qi
gaius-qi approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 753dcb9 into main Sep 30, 2021
@gaius-qi gaius-qi deleted the feature/update-k8s-docs branch September 30, 2021 10:26
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
docs: update kubernetes docs (#705)
feaa0a9 
* docs: update kubernetes docs

Signed-off-by: Jim Ma <majinjing3@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
fix: --storage-credential-path in dfget description (dragonflyoss#705)
89a339e 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim3ma @yxxhero @gaius-qi