Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC metric #686

Merged
merged 20 commits into from
Sep 30, 2021
Merged

GRPC metric #686

merged 20 commits into from
Sep 30, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 27, 2021

Description

  • Refactor grpc server.
  • Add scheduler grpc metrics.
  • Add cdn grpc metrics.

Related Issue

Fixes #658

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Sep 27, 2021
@gaius-qi gaius-qi self-assigned this Sep 27, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner September 27, 2021 09:08
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi changed the title Feature/grpc metrics GRPC metric Sep 27, 2021
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi requested a review from a team as a code owner September 27, 2021 11:22
@gaius-qi gaius-qi requested a review from ansinlee September 27, 2021 11:22
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #686 (b102777) into main (3589f65) will decrease coverage by 0.03%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   38.63%   38.60%   -0.04%     
==========================================
  Files          89       89              
  Lines        6975     6968       -7     
==========================================
- Hits         2695     2690       -5     
+ Misses       3897     3896       -1     
+ Partials      383      382       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 38.60% <9.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdn/rpcserver/rpcserver.go 0.00% <0.00%> (-0.67%) ⬇️
client/daemon/daemon.go 0.00% <0.00%> (ø)
client/daemon/rpcserver/rpcserver.go 34.28% <0.00%> (ø)
manager/config/config.go 0.00% <ø> (ø)
scheduler/config/config.go 4.59% <ø> (ø)
cdn/supervisor/cdn/manager.go 61.40% <33.33%> (ø)
client/daemon/peer/peertask_stream.go 55.66% <0.00%> (-2.27%) ⬇️
client/daemon/peer/peertask_base.go 35.14% <0.00%> (+0.62%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
cdn/cdn.go Outdated Show resolved Hide resolved
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 6f15b04 into main Sep 30, 2021
@gaius-qi gaius-qi deleted the feature/grpc-metrics branch September 30, 2021 09:32
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metrics scheduler and CDN
4 participants