Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update charts submodule #583

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Update charts submodule.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 26, 2021
@gaius-qi gaius-qi self-assigned this Aug 26, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 26, 2021 07:41
@codecov-commenter
Copy link

Codecov Report

Merging #583 (44423c7) into main (581f178) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   39.00%   39.05%   +0.04%     
==========================================
  Files          86       86              
  Lines        6655     6655              
==========================================
+ Hits         2596     2599       +3     
+ Misses       3689     3686       -3     
  Partials      370      370              
Flag Coverage Δ
e2etests ?
unittests 39.05% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.68% <0.00%> (+0.63%) ⬆️

@gaius-qi gaius-qi merged commit 6bb33f5 into main Aug 26, 2021
@gaius-qi gaius-qi deleted the feature/update-charts-submodule branch August 26, 2021 11:31
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants