-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toleration to run on all nodes (even tainted ones) #6
Comments
thank you for the tip! Will release soon(ish) a helm chart version that will allow to set tolerations. |
Hi, I'm potentially interested in contributing to the helm chart, what's the repo for contributing to it? Found the helm chart but that links to this repo that doesn't have a helm chart. Thanks! |
Please add tolerations support to the helm chart. |
Created #9 for to add tolerations for all taints |
@anderson4u2 The chart is in the docs subdir: https://github.com/draganm/missing-container-metrics/tree/master/docs/missing-container-metrics |
We segment our node groups with taints, and by default missing-container-metrics does not install on any nodes with taints. Adding the toleration
Would ensure the daemonset is running on all nodes. Alternatively, allowing for setting tolerations in the Helm chart would give deployers the ability to manage this.
The text was updated successfully, but these errors were encountered: