February 2020 update broke typescript and javascript syntax

[sergejostir]

There were some changes introducted in February 2020 that break highligting for JS.

More info: microsoft/vscode#92308

[leandrocunha]

You are right @sergiz a strange behavior for me here. Look the component written in white color:

[DoanVanThuong]

Same issue

[sergejostir]

Of course you have the same issue, it affects every single theme out there which is not adjusted to the new method.

I opened this issue to bring it to attention of the maintainer. For now you can simply use the "fix" from the link above.

[dsifford]

I'll look into this later this afternoon and push out a fix.

In the meantime, can someone comment a section of code that I can copy paste to reproduce? (screenshots are helpful, but written code is easier!)

Thanks!

[dsifford]

Update: still waiting for my distro's package repository to push out the update for vscode. Can't repro til that happens. Should be in the next day or two.

[sergejostir]

I'll look into this later this afternoon and push out a fix.

In the meantime, can someone comment a section of code that I can copy paste to reproduce? (screenshots are helpful, but written code is easier!)

Thanks!

Basically any JS code.

console.log()

already has wrong highlighting.

[dsifford]

Got it, thanks!

[DoanVanThuong]

editor.semanticHighlighting.enabled": false

it work for me

[EduardoAraujoB]

the test colors broke with this new vscode update

[dsifford]

Still waiting for my distro to push the vscode update, but when that happens I'll have a fix pushed out shortly after.

[EduardoAraujoB]

Ok, thanks

[EduardoAraujoB]

editor.semanticHighlighting.enabled": false

it work for me

worked for me too

[dsifford]

Just don't forget to re-enable that when the fix gets pushed out. That's gonna be a killer feature!

[EduardoAraujoB]

Nice, I will re-enable it later

[JimmyMultani]

Hey @dsifford, has your distro pushed an update yet?

[dsifford]

Ugh, no! Getting pretty annoyed and might have to download insiders or something in the meantime.

[dsifford]

@JimmyMultani Update: just compiled it myself and i got the update finally... I'll look into these issues later this evening or tomorrow at the latest.

[dsifford]

Okay, so here's the bummer... It doesn't appear that this is actually fixable beyond turning off semantic highlighting right now.

I quickly combed through some of the issues checking syntax groups and they are all being highlighted correctly, when identified correctly. The issue is, however, that there is some inconsistencies with identification (using react as an example: class components vs function components are highlighted differently).

So, for now, I'll keep this open, but there's not much more I can do until the issue is sorted out upstream.

[JimmyMultani]

Yeah, that is a bummer. Thanks for looking into it, @dsifford.

…

On Wed., Mar. 18, 2020, 8:55 a.m. Derek Sifford, ***@***.***> wrote: Okay, so here's the bummer... It doesn't appear that this is actually fixable beyond turning off semantic highlighting right now. I quickly combed through some of the issues checking syntax groups and they are all being highlighted correctly, when identified correctly. The issue is, however, that there is some inconsistencies with identification (using react as an example: class components vs function components are highlighted differently). So, for now, I'll keep this open, but there's not much more I can do until the issue is sorted out upstream. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJY2BCFY64D3FFPKZKUQH3RIDAFBANCNFSM4LEZPELQ> .

[JimmyMultani]

FYI @dsifford, the latest VSCode update now defaults semantic highlighting to false. So the issue is no longer present.

microsoft/vscode#92740

[sergejostir]

So this can then be turned into a feature request to make Dracula theme support semantic highlighting.

[dsifford]

@sergiz It's on my radar. Plan on deep diving this when i get some extra time (possibly this weekend).

[sergejostir]

I guess that this has already been resolved.