From b737e32b793f13fe9f317951959690f3349064d4 Mon Sep 17 00:00:00 2001 From: Dylan Kelly Date: Fri, 6 Oct 2023 13:20:59 +1100 Subject: [PATCH 1/2] chore(@dpc-sdp/ripple-tide-publication): :bug: [R20-1574] fix publication preview menu issue --- .../server/api/tide/publication-index.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/ripple-tide-publication/server/api/tide/publication-index.ts b/packages/ripple-tide-publication/server/api/tide/publication-index.ts index 9294dae254..138fd59831 100644 --- a/packages/ripple-tide-publication/server/api/tide/publication-index.ts +++ b/packages/ripple-tide-publication/server/api/tide/publication-index.ts @@ -69,10 +69,8 @@ class TidePublicationIndexApi extends TideApiBase { ) return siteData } catch (error: any) { - // Could be 404? - throw new ApplicationError('Error fetching publication index', { - cause: error - }) + // Could be 404? publication could be in share or preview so need to ignore this error and render page anyway + logger.error(`Error fetching publication index`, error) } } } From acd09f34bee9fd567005917813099b9fb47b4b8d Mon Sep 17 00:00:00 2001 From: Dylan Kelly Date: Fri, 6 Oct 2023 13:36:11 +1100 Subject: [PATCH 2/2] chore(@dpc-sdp/ripple-tide-publication): :rotating_light: fix unused var --- .../server/api/tide/publication-index.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/ripple-tide-publication/server/api/tide/publication-index.ts b/packages/ripple-tide-publication/server/api/tide/publication-index.ts index 138fd59831..33683fe71a 100644 --- a/packages/ripple-tide-publication/server/api/tide/publication-index.ts +++ b/packages/ripple-tide-publication/server/api/tide/publication-index.ts @@ -1,10 +1,7 @@ import jsonapiParse from 'jsonapi-parse' import { defineEventHandler, getQuery, H3Event } from 'h3' import { createHandler, TideApiBase, logger } from '@dpc-sdp/ripple-tide-api' -import { - ApplicationError, - BadRequestError -} from '@dpc-sdp/ripple-tide-api/errors' +import { BadRequestError } from '@dpc-sdp/ripple-tide-api/errors' import type { RplTideModuleConfig, IRplTideModuleMapping,