From b899a329fab86404d6a0c6df90c54b61015c8c34 Mon Sep 17 00:00:00 2001
From: David Featherston <david@lambry.com>
Date: Thu, 14 Nov 2024 08:40:39 +1100
Subject: [PATCH] chore(@dpc-sdp/ripple-tide-search): update filters label and
 always show filter button

---
 .../test/features/search-listing/filters.feature       |  1 -
 .../step_definitions/components/custom-collection.ts   |  2 +-
 .../step_definitions/content-types/listing.ts          | 10 +++++-----
 .../components/TideSearchListingPage.vue               |  3 +--
 .../ripple-tide-search/components/TideSearchPage.vue   |  2 +-
 .../components/global/TideCustomCollection.vue         |  3 +--
 6 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/examples/nuxt-app/test/features/search-listing/filters.feature b/examples/nuxt-app/test/features/search-listing/filters.feature
index 24cea2d7a8..3f87344d96 100644
--- a/examples/nuxt-app/test/features/search-listing/filters.feature
+++ b/examples/nuxt-app/test/features/search-listing/filters.feature
@@ -14,7 +14,6 @@ Feature: Search listing - Filter
 
     When I visit the page "/filters"
     Then the search listing filters section should be open
-    And the filters toggle should be hidden
 
   @mockserver
   Example: Raw filter - Should reflect the value from the URL
diff --git a/packages/ripple-test-utils/step_definitions/components/custom-collection.ts b/packages/ripple-test-utils/step_definitions/components/custom-collection.ts
index 5e5aef64ae..c146265c62 100644
--- a/packages/ripple-test-utils/step_definitions/components/custom-collection.ts
+++ b/packages/ripple-test-utils/step_definitions/components/custom-collection.ts
@@ -118,7 +118,7 @@ Then(
 When(`I toggle the content collection filters`, () => {
   cy.get(`[data-component-type="TideCustomCollection"]`)
     .find(`button`)
-    .contains('Refine search')
+    .contains('Filters')
     .click()
 })
 
diff --git a/packages/ripple-test-utils/step_definitions/content-types/listing.ts b/packages/ripple-test-utils/step_definitions/content-types/listing.ts
index 5345e354b2..48c61d11d9 100644
--- a/packages/ripple-test-utils/step_definitions/content-types/listing.ts
+++ b/packages/ripple-test-utils/step_definitions/content-types/listing.ts
@@ -356,7 +356,7 @@ Then(
 )
 
 When(`I toggle the search listing filters section`, () => {
-  cy.get(`button`).contains('Refine search').as('refineBtn')
+  cy.get(`button`).contains('Filters').as('refineBtn')
   cy.wait(300)
   cy.get('@refineBtn').click()
 })
@@ -374,15 +374,15 @@ Then(
   (filterCount: number) => {
     if (filterCount === 0) {
       cy.get(`button`)
-        .contains('Refine search')
+        .contains('Filters')
         .should(($div) => {
-          expect($div.text().trim()).equal(`Refine search`)
+          expect($div.text().trim()).equal(`Filters`)
         })
     } else {
       cy.get(`button`)
-        .contains('Refine search')
+        .contains('Filters')
         .should(($div) => {
-          expect($div.text().trim()).equal(`Refine search (${filterCount})`)
+          expect($div.text().trim()).equal(`Filters (${filterCount})`)
         })
     }
   }
diff --git a/packages/ripple-tide-search/components/TideSearchListingPage.vue b/packages/ripple-tide-search/components/TideSearchListingPage.vue
index 9c43c28e1f..d896b7f260 100644
--- a/packages/ripple-tide-search/components/TideSearchListingPage.vue
+++ b/packages/ripple-tide-search/components/TideSearchListingPage.vue
@@ -336,7 +336,7 @@ const numAppliedFilters = computed(() => {
 })
 
 const toggleFiltersLabel = computed(() => {
-  let label = 'Refine search'
+  let label = 'Filters'
 
   return numAppliedFilters.value
     ? `${label} (${numAppliedFilters.value})`
@@ -423,7 +423,6 @@ watch(
           </template>
           <RplSearchBarRefine
             v-if="
-              !searchListingConfig?.showFiltersOnLoad &&
               !searchListingConfig?.showFiltersOnly &&
               userFilters &&
               userFilters.length > 0
diff --git a/packages/ripple-tide-search/components/TideSearchPage.vue b/packages/ripple-tide-search/components/TideSearchPage.vue
index 7c40b5666c..3950473b67 100644
--- a/packages/ripple-tide-search/components/TideSearchPage.vue
+++ b/packages/ripple-tide-search/components/TideSearchPage.vue
@@ -112,7 +112,7 @@ const filtersExpanded = ref(false)
 const submitFiltersLabel = 'Apply search filters'
 
 const toggleFiltersLabel = computed(() => {
-  let label = 'Refine search'
+  let label = 'Filters'
 
   return searchState.value?.filters?.length
     ? `${label} (${searchState.value.filters.length})`
diff --git a/packages/ripple-tide-search/components/global/TideCustomCollection.vue b/packages/ripple-tide-search/components/global/TideCustomCollection.vue
index b2e85ad3cd..c178a1e90f 100644
--- a/packages/ripple-tide-search/components/global/TideCustomCollection.vue
+++ b/packages/ripple-tide-search/components/global/TideCustomCollection.vue
@@ -447,7 +447,7 @@ const numAppliedFilters = computed(() => {
 })
 
 const toggleFiltersLabel = computed(() => {
-  let label = 'Refine search'
+  let label = 'Filters'
 
   return numAppliedFilters.value
     ? `${label} (${numAppliedFilters.value})`
@@ -619,7 +619,6 @@ const locationOrGeolocation = computed(() => {
         <div class="tide-search-refine-wrapper">
           <RplSearchBarRefine
             v-if="
-              !searchListingConfig?.showFiltersOnLoad &&
               !searchListingConfig?.showFiltersOnly &&
               userFilters &&
               userFilters.length > 0