Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getA11ySelectionMessage is not called #1227

Closed
devacc5566 opened this issue Feb 1, 2021 · 1 comment · Fixed by #1582 · May be fixed by InfiniteLove2020/gutenberg#6
Closed

getA11ySelectionMessage is not called #1227

devacc5566 opened this issue Feb 1, 2021 · 1 comment · Fixed by #1582 · May be fixed by InfiniteLove2020/gutenberg#6
Labels

Comments

@devacc5566
Copy link

  • downshift version: v6.0.16
  • node version: v14.15.4
  • npm (or yarn) version: 6.14.10

Relevant code or config

a11y message functions overriden:

    getA11ySelectionMessage: () => console.log('getA11ySelectionMessage'),
    getA11yStatusMessage: () => console.log('getA11yStatusMessage'),
   

Both functions don't return any value because I just wanted to check if when it is called.

https://codesandbox.io/s/clever-dream-v6o6s?file=/src/hooks/useCombobox/basic-usage.js:413-557

What you did:

Select item anyhow.
Check console logs and notice that getA11ySelectionMessage entry is not available despite item is selected.

Problem description:
useCombobox calls useA11yMessageSetter function two times: first and second
There is updateA11yStatus called which is debounced.
After seleted item change there is getA11yStatusMessage fuction called immediately and returns empty string so item change announcement is blocked.

Suggested solution

Debounced updateA11yStatus can be separately debounced for getA11ySelectionMessage and getA11yStatusMessage.

Would you like me to propose a PR with solution?

@devacc5566 devacc5566 changed the title getA11ySelectionMessage is not fired. getA11ySelectionMessage is not called Feb 1, 2021
@silviuaavram
Copy link
Collaborator

Yes please! Sorry I missed this issue.

@silviuaavram silviuaavram mentioned this issue Dec 19, 2022
Closed
10 tasks
@silviuaavram silviuaavram mentioned this issue Jul 15, 2023
Closed
7 tasks
mergify bot referenced this issue in SvenKirschbaum/musikbot-frontend Mar 22, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [downshift](https://downshift-js.com) ([source](https://togithub.com/downshift-js/downshift)) | [`^8.3.1` -> `^9.0.0`](https://renovatebot.com/diffs/npm/downshift/8.5.0/9.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/downshift/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/downshift/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/downshift/8.5.0/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/downshift/8.5.0/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>downshift-js/downshift (downshift)</summary>

### [`v9.0.0`](https://togithub.com/downshift-js/downshift/releases/tag/v9.0.0)

[Compare Source](https://togithub.com/downshift-js/downshift/compare/v8.5.0...v9.0.0)

##### Features

-   V9 ([#&#8203;1582](https://togithub.com/downshift-js/downshift/issues/1582)) ([5b0d503](https://togithub.com/downshift-js/downshift/commit/5b0d5031c1c11455ba18fa1516a259b4ed9357a1))

##### BREAKING CHANGES

-   Release Downshift v9.



**Why**:
Release the changes in:

-   [https://github.com/downshift-js/downshift/pull/1580](https://togithub.com/downshift-js/downshift/pull/1580)
-   [https://github.com/downshift-js/downshift/pull/1579](https://togithub.com/downshift-js/downshift/pull/1579)
-   [https://github.com/downshift-js/downshift/pull/1583](https://togithub.com/downshift-js/downshift/pull/1583)

Closes [https://github.com/downshift-js/downshift/issues/1322](https://togithub.com/downshift-js/downshift/issues/1322).
Closes [https://github.com/downshift-js/downshift/issues/1244](https://togithub.com/downshift-js/downshift/issues/1244).
Closes [https://github.com/downshift-js/downshift/issues/1227](https://togithub.com/downshift-js/downshift/issues/1227)
Closes [https://github.com/downshift-js/downshift/issues/1225](https://togithub.com/downshift-js/downshift/issues/1225).



**How**:
Merged the PRs in this branch.



**Checklist**:





-   \[x] Documentation
-   \[x] Tests
-   \[x] TypeScript Types
-   \[ ] Flow Types
-   \[x] Ready to be merged 



</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-frontend).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants