-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beam search #258
Comments
to be clear: i'm also happy to write a patch for it if thats feasible |
Patches/PRs are always welcome! In cases of large or complicated changes, we do prefer to have high-level discussions first, though, so that we make the best use of contributors' time. |
Did anything come of this discussion privately? |
We've been working on improving the performance of the basic sampling steps recently and will start addressing alternative approaches soon after. |
Now that #416 has been merged we can consider implementing Beam Search in Outlines. The samplers currently return next token ids. We will now need them to return the next token ids, as well as the "ancestor" of these token ids, i.e. the sequences to which they need to be appended. The list of ancestors will allow to update:
|
Hello! I'm trying to understand the capabilities of the current interface, and it seems like kwargs aren't passed to the underlying models, are they? I'd like to do stuff like beam search so i can get useful structured queries that are "good quality"
The text was updated successfully, but these errors were encountered: