Document the source for hardcoded regex patterns #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torymur
reviewed
Jan 28, 2025
torymur
approved these changes
Jan 28, 2025
torymur
force-pushed
the
document-regex
branch
from
2ecda9c to
faf9d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex can be clumsy and are often a source of bugs (e.g., #154 and #155). While iterating on fixes is nice, it’s even better to document how we arrived at these patterns, as already mentioned here!
n.b. I’m not sure if the links above are the correct ones... this PR is just a reminder that we should ideally do something ;)