Dispose Cursor only if it is owned by the creator. #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dreddy-work
changed the title
dreddy-work
changed the title
This was referenced Mar 16, 2023
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating flaky tests, found that Cursor Handle is being set to null even if the cursor is not owned by the specific scope. This has been the case since .NET framework. Disposing handle only if owned by creator.
Some static Cursors in WinForms are incorrectly categorized as
owned. Making any change aroundownedflag on these could break existing applications. In this change, we are recreating static cursors if their handle is disposed.Related #8810
fixes #8373
Microsoft Reviewers: Open in CodeFlow