Fix menu item without sub menu leaking focus on arrow keys #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-elnovikova
added
the
waiting-review
| @@ -542,12 +542,12 @@ protected internal override bool ProcessDialogKey(Keys keyData) | |||
| { | |||
| Keys keyCode = (Keys)keyData & Keys.KeyCode; | |||
|
|
|||
| // Items on the overflow should have the same kind of keyboard handling as a toplevel | |||
There was a problem hiding this comment.
nitpick: please end comments with a dot
v-elnovikova
force-pushed
the
Issue_8591_Fix_ProcessDialogKey_method
branch
from
1ca0df4
to
7dca352
Compare
…Up and Down keys when item has no sub-items
v-elnovikova
force-pushed
the
Issue_8591_Fix_ProcessDialogKey_method
branch
from
7dca352
to
b4ffd32
Compare
|
/azp run |
Tanya-Solyanik
approved these changes
Feb 9, 2023
|
Azure Pipelines successfully started running 2 pipeline(s). |
Tanya-Solyanik
added
ready-to-merge
This was referenced Feb 9, 2023
Closed
ghost
removed
the
ready-to-merge
This was referenced Feb 9, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8591
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
When empty menu item is focused, Down key switches focus to form button:
Before.mp4
After
When empty menu item is focused, Down key does nothing, menu is still focused:
After.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow