Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GetStandardValues implementations to remove ArrayList #8276

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Refactor GetStandardValues implementations to remove ArrayList #8276

merged 4 commits into from
Dec 1, 2022

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Nov 24, 2022 •
edited by ghost
Loading

Related #8140

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner November 24, 2022 00:41
@ghost ghost assigned elachlan Nov 24, 2022
@runfoapp runfoapp bot mentioned this pull request Nov 24, 2022
Closed
JeremyKuhne
JeremyKuhne requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise looks good!

src/System.Windows.Forms/src/System/Windows/Forms/TextBoxAutoCompleteSourceConverter.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/SpecialFolderEnumConverter.cs Outdated Show resolved Hide resolved
@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Nov 28, 2022
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 29, 2022
lonitra
lonitra previously approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreddy-work dreddy-work added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Dec 1, 2022
@dreddy-work dreddy-work enabled auto-merge (squash) December 1, 2022 18:16
@dreddy-work dreddy-work merged commit c872b6e into dotnet:main Dec 1, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Dec 1, 2022
@elachlan elachlan deleted the GetStandardValues-ArrayList branch December 1, 2022 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

@dreddy-work dreddy-work dreddy-work approved these changes

@lonitra lonitra lonitra left review comments

Assignees

@elachlan elachlan

Labels
ready-to-merge PRs that are ready to merge but worth notifying the internal team.
Projects
None yet
Milestone
8.0 Preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@elachlan @JeremyKuhne @lonitra @dreddy-work