Adding more Skip attributes for flaky tests
#6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related Issue dotnet#6610 and Issue dotnet#6654 These tests fail sometimes in x86 CI build, that blocks deployment of fixes into sdk.
vladimir-krestov
added
the
waiting-review
vladimir-krestov
commented
Feb 9, 2022
| @@ -51,7 +51,8 @@ public async Task TabControl_TabPage_IsHoveredWithMouse_IsFalse_WhenMouseIs_Outs | |||
| }); | |||
| } | |||
|
|
|||
| [WinFormsFact] | |||
| [ActiveIssue("https://github.com/dotnet/winforms/issues/6654")] | |||
| [WinFormsFact(Skip = "Flaky tests, see: https://github.com/dotnet/winforms/issues/6654")] | |||
There was a problem hiding this comment.
Didn't add conditional Fact due to #6653
dreddy-work
approved these changes
Feb 9, 2022
ghost
locked as resolved and limited conversation to collaborators
RussKie
removed
the
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue #6610 and Issue #6654
These tests fail sometimes in x86 CI build, that blocks deployment of fixes into sdk.
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow