-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UI tests #10809
Merged
Merged
Enable UI tests #10809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dotnet#6654 Closes dotnet#9318
ghost
assigned sharwell
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10809 +/- ##
===================================================
+ Coverage 72.60935% 73.19928% +0.58992%
===================================================
Files 2931 3066 +135
Lines 620281 632942 +12661
Branches 46942 47376 +434
===================================================
+ Hits 450382 463309 +12927
- Misses 161541 166093 +4552
+ Partials 8358 3540 -4818
Flags with carried forward coverage won't be shown. Click here to find out more. |
sharwell
force-pushed
the
enable-tests
branch
from
February 2, 2024 20:52
3428edc
to
3460db6
Compare
sharwell
force-pushed
the
enable-tests
branch
from
February 3, 2024 00:39
7ed8078
to
9c4a23b
Compare
sharwell
force-pushed
the
enable-tests
branch
from
February 3, 2024 17:20
9c4a23b
to
2b13502
Compare
Reduces the number of uploaded reports that need to be processed by codecov.io, since the determination of unit tests vs. integration tests in test sources is immediately clear from the file path.
Tanya-Solyanik
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior testing indicated that the inclusion of a screen capture in the render loop (part of #10552) was sufficient to stabilize the mouse interactions for integration tests. Even with the retry mechanism disabled I have not been able to reproduce a failure.
Merge commit recommended for clarity of the individual changes (note that CI was passed for each commit individually).
Closes #6654
Closes #9318
Microsoft Reviewers: Open in CodeFlow