Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UI tests #10809

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Enable UI tests #10809

merged 4 commits into from
Feb 5, 2024

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Feb 2, 2024

Prior testing indicated that the inclusion of a screen capture in the render loop (part of #10552) was sufficient to stabilize the mouse interactions for integration tests. Even with the retry mechanism disabled I have not been able to reproduce a failure.

Merge commit recommended for clarity of the individual changes (note that CI was passed for each commit individually).

Closes #6654
Closes #9318

Microsoft Reviewers: Open in CodeFlow

@sharwell sharwell requested a review from a team as a code owner February 2, 2024 18:49
@ghost ghost assigned sharwell Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (904487a) 72.60935% compared to head (6a80242) 73.19928%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10809         +/-   ##
===================================================
+ Coverage   72.60935%   73.19928%   +0.58992%     
===================================================
  Files           2931        3066        +135     
  Lines         620281      632942      +12661     
  Branches       46942       47376        +434     
===================================================
+ Hits          450382      463309      +12927     
- Misses        161541      166093       +4552     
+ Partials        8358        3540       -4818     
Flag Coverage Δ
Debug 73.19928% <ø> (+0.58992%) ⬆️
integration 18.31063% <ø> (?)
production 46.67554% <ø> (+3.08898%) ⬆️
test 95.00759% <ø> (-2.36757%) ⬇️
unit 43.58305% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sharwell sharwell marked this pull request as draft February 2, 2024 20:22
Reduces the number of uploaded reports that need to be processed by
codecov.io, since the determination of unit tests vs. integration tests
in test sources is immediately clear from the file path.
@sharwell sharwell marked this pull request as ready for review February 4, 2024 18:45
@ghost ghost removed the draft draft PR label Feb 4, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sharwell sharwell merged commit a998a18 into dotnet:main Feb 5, 2024
9 checks passed
@sharwell sharwell deleted the enable-tests branch February 5, 2024 22:34
@lonitra lonitra added this to the 9.0 Preview2 milestone Feb 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants