Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs to add tests attributes with conditional skipping for UI tests #6653

Closed
vladimir-krestov opened this issue Feb 9, 2022 · 2 comments · Fixed by #6658
Closed

Needs to add tests attributes with conditional skipping for UI tests #6653

vladimir-krestov opened this issue Feb 9, 2022 · 2 comments · Fixed by #6658
Labels
test-bug Problem in test source code (most likely) test-enhancement Improvements of test source code

Comments

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Feb 9, 2022 •
edited
Loading

  • .NET Core Version: 7.0

Problem description:

  • Needs to add the ability to skip some tests in a specific architecture for UI tests and MAUI tests like we did it for unit tests (see #6599). We can't use the attributes from unit tests utilities, because UI tests doesn't have a reference to them.
    Based on this comment

Solutions:

  • Copy-paste ConditionalWinFormsFactAttribute and ConditionalWinFormsTheoryAttribute
  • Or add the dependency to UI tests project

Will this feature affect UI controls? No
@vladimir-krestov vladimir-krestov added the test-enhancement Improvements of test source code label Feb 9, 2022
This was referenced Feb 9, 2022
Merged
Merged
vladimir-krestov added a commit to vladimir-krestov/winforms that referenced this issue Feb 9, 2022
@vladimir-krestov
Added a dependency to conditional attributes
37031e9 
for IntegrationTests project.
Fixes dotnet#6653
vladimir-krestov added a commit to vladimir-krestov/winforms that referenced this issue Feb 9, 2022
@vladimir-krestov
Reworked conditional attributes to have ability
4e9386c 
to add several unsupported architectures
Fixes dotnet#6653
@vladimir-krestov vladimir-krestov mentioned this issue Feb 9, 2022
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Feb 9, 2022
@dreddy-work
Copy link
Member

Not sure where you are tracking flaky tests. here is another to add to that list:
image

@dreddy-work
Copy link
Member

buildId=1611672

@merriemcgaw merriemcgaw added the test-bug Problem in test source code (most likely) label Feb 18, 2022
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 12, 2022
@vladimir-krestov
Added a dependency to conditional attributes
0f3c16c 
for IntegrationTests project.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 12, 2022
@vladimir-krestov
Reworked conditional attributes to have ability
c1dda6f 
to add several unsupported architectures
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 12, 2022
Replace conditional test attributes with SkipOnArchitectureAttribute
0685d0b 
which is implemented in a similar way to existing SkipOn* attributes.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 12, 2022
Replace conditional test attributes with SkipOnArchitectureAttribute
4f9db05 
which is implemented in a similar way to existing SkipOn* attributes.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 13, 2022
@vladimir-krestov
Added a dependency to conditional attributes
50bf961 
for IntegrationTests project.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 13, 2022
@vladimir-krestov
Replace conditional test attributes with SkipOnArchitectureAttribute.
4898ff3 
It is implemented in a similar way to existing SkipOn* attributes
from Microsoft.DotNet.XUnitExtensions library,
allowing to set several unsupported architectures.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 15, 2022
@vladimir-krestov
Added a dependency to conditional attributes
08bb5e8 
for IntegrationTests project.
Fixes dotnet#6653
dmitrii-drobotov pushed a commit to vladimir-krestov/winforms that referenced this issue Apr 15, 2022
@vladimir-krestov
Replace conditional test attributes with SkipOnArchitectureAttribute.
f3a573e 
It is implemented in a similar way to existing SkipOn* attributes
from Microsoft.DotNet.XUnitExtensions library,
allowing to set several unsupported architectures.
Fixes dotnet#6653
Tanya-Solyanik pushed a commit that referenced this issue Apr 15, 2022
@vladimir-krestov
Reworking conditional Skip attributes (#6658)
d2f9c33 
It is implemented in a similar way to existing SkipOn* attributes
from Microsoft.DotNet.XUnitExtensions library,
allowing to set several unsupported architectures.
Fixes #6653
Co-authored-by: Dmitrii Drobotov <dmitriy.drobotov@akvelon.com>
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Apr 15, 2022
@Tanya-Solyanik Tanya-Solyanik added this to the 7.0 Preview4 milestone Apr 15, 2022
@RussKie RussKie removed this from the 7.0 Preview4 milestone Apr 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
test-bug Problem in test source code (most likely) test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reworking conditional Skip attributes vladimir-krestov/winforms
5 participants
@RussKie @Tanya-Solyanik @merriemcgaw @dreddy-work @vladimir-krestov