Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize function pointers for interop #4135

Closed
JeremyKuhne opened this issue Oct 19, 2020 · 5 comments
Closed

Utilize function pointers for interop #4135

JeremyKuhne opened this issue Oct 19, 2020 · 5 comments
Labels
enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Improve performance, flag performance regressions across core releases

Comments

@JeremyKuhne
Copy link
Member

Function pointers provide better performance. Creating this issue to discuss utilizing them in Windows Forms interop.

Things we should consider / look at:

  • Win32 callbacks
  • High usage COM interfaces
  • ?
@JeremyKuhne JeremyKuhne added enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Improve performance, flag performance regressions across core releases labels Oct 19, 2020
@JeremyKuhne JeremyKuhne added this to the 6.0 milestone Oct 19, 2020
@JeremyKuhne
Copy link
Member Author

Some Runtime changes:

dotnet/runtime#43514
dotnet/runtime#39752
dotnet/runtime#39082

@kpreisser kpreisser mentioned this issue Oct 25, 2020
Merged
@merriemcgaw merriemcgaw modified the milestones: 6.0, 7.0 Jun 11, 2021
This was referenced Jun 24, 2022
Closed
Closed
@merriemcgaw merriemcgaw modified the milestones: .NET 7.0, .NET 8.0 Aug 11, 2022
@elachlan
Copy link
Contributor

elachlan commented Nov 7, 2022

@RussKie Should we close this issue because of #7445 or does this compliment it?

@RussKie
Copy link
Member

RussKie commented Nov 7, 2022

Thank you for going through the backlog. If we're importing callbacks from CsWin32 then, I think, we can close it. If we still have manually created callbacks - then I think this may still be relevant.

I let @JeremyKuhne to make a call on this, since he's opened the issue.

@JeremyKuhne
Copy link
Member Author

It is related to the other, but we should keep it open to attach known instances of this.

@JeremyKuhne
Copy link
Member Author

We've been doing this now, no longer a need to track.

@ghost ghost removed this from the .NET 8.0 milestone Aug 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Product code improvement that does NOT require public API changes/additions tenet-performance Improve performance, flag performance regressions across core releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elachlan @RussKie @JeremyKuhne @merriemcgaw