Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests for shared components to System.Private.Windows.Core.Tests #12862

Closed
Tracked by #12502
Tanya-Solyanik opened this issue Jan 30, 2025 · 0 comments
Closed
Tracked by #12502
Assignees
Labels
priority-2 Work that is important, but not critical for the release
Milestone

Comments

@Tanya-Solyanik
Copy link
Member

Jeremy is currently moving Clipboard and drag and drop-related implementation code to System.Private.Windows.Core assembly. This assembly does not reference System.Windows.Forms project because it is lower in the layering.
Some classes that were moved, such as https://github.com/dotnet/winforms/blob/main/src/System.Private.Windows.Core/src/System/Private/Windows/Ole/BinaryFormatUtilities.cs
have dedicated tests in System.Windows.Forms.Tests assembly. These tests can be moved to a new test assembly (SystemPrivate.Windows.Core) that does not use System.Windows.Forms namespace. Tests would require Mocks for the new interfaces to avoid taking dependency on the System.Windows.Forms project.
Some test utilities can be moved from the System.Windows.Forms.Tests into System.Private.Windows.Core.TestUtilities, for example -

@Tanya-Solyanik Tanya-Solyanik modified the milestones: Future, .NET 10.0 Jan 30, 2025
@Tanya-Solyanik Tanya-Solyanik self-assigned this Jan 30, 2025
@Tanya-Solyanik Tanya-Solyanik added untriaged The team needs to look at this issue in the next triage priority-2 Work that is important, but not critical for the release labels Jan 30, 2025
@merriemcgaw merriemcgaw removed the untriaged The team needs to look at this issue in the next triage label Feb 18, 2025
@merriemcgaw merriemcgaw closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

2 participants