Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language features in metadata / decompiled source files #5787

Closed
dibarbet opened this issue Jun 13, 2023 · 8 comments · Fixed by dotnet/roslyn#74488
Closed

Support language features in metadata / decompiled source files #5787

dibarbet opened this issue Jun 13, 2023 · 8 comments · Fixed by dotnet/roslyn#74488
Assignees
Milestone

Comments

@dibarbet
Copy link
Member

Currently it looks like all metadata as source files are going into the LSP misc workspace. This appears to be because TryAddDocumentToWorkspace never gets called. In VS this is called when the file is opened (the misc files workspace sees it and puts the document in the workspace). Since a solution is never created in the metadata workspace because the file is never added, the metadata workspace is also not registered.

@dibarbet dibarbet added this to the Backlog milestone Jun 13, 2023
@arkalyanms arkalyanms modified the milestones: Backlog, Post GA Jun 16, 2023
@dibarbet dibarbet modified the milestones: Post GA, Next Aug 2, 2023
@dibarbet dibarbet changed the title MetadataAsSource files not added to MetadataAsSource workspace (and workspace is not registered Support language features in metadata / decompiled source files Sep 13, 2023
@dibarbet
Copy link
Member Author

Scenarios here

  1. Go to definition from metadata references
  2. Document outline - Provide outline and breadcrumbs for read-only (generated, decompiled) sources #6341

@daniel-tonic
Copy link

Is there any update on this? This seems like a pretty big miss from a feature-parity perspective and it's been several months since this ticket was updated.

@hsm207
Copy link

hsm207 commented Mar 31, 2024

Just encountered #6021 but only for some projects in a solution.

I'm on version 2.22.5 and everytime I reload the window, the C# output pane shows this:

Using dotnet configured on PATH
Dotnet path: /usr/share/dotnet/dotnet
Activating C# + C# Dev Kit...
waiting for named pipe information from server...
[stdout] {"pipeName":"/tmp/c8da874b.sock"}
received named pipe information from server
attempting to connect client to server...
client has connected to server
[Info  - 3:42:10 AM] [Program] Language server initialized
[Error - 3:42:11 AM] Request textDocument/semanticTokens/range failed.
  Message: Unsupported extension '' and LSP language id ''
  Code: -32000 
[object Object]
[Error - 3:42:11 AM] Request textDocument/semanticTokens/range failed.
  Message: Unsupported extension '' and LSP language id ''
  Code: -32000 
[object Object]

@whitecostume
Copy link

Still not solved?

@dibarbet
Copy link
Member Author

This should be available in the next prerelease update to the extension. Will update here once it is published.

@dibarbet
Copy link
Member Author

This should now be available in v2.41.26 (pre-release).

@SherbetHead
Copy link

@dibarbet, thank you for fixing this. it was working great for a while, but unfortunately I'm having this issue again with the latest pre-release version and the latest release version of c# extension. Your fix was working when vs code was opening source files as "decompiled metadata as source" but it seems that the most recent versions of the c# extension are opening the same source files in a SymbolCache directory.

@dibarbet
Copy link
Member Author

@SherbetHead yeah there is an issue with sourcelink in the latest version. We're working on a fix and should have it out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants