Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-open source license in vstest #3538

Closed
omajid opened this issue Jun 23, 2023 · 2 comments · Fixed by dotnet/dotnet#32
Closed

Non-open source license in vstest #3538

omajid opened this issue Jun 23, 2023 · 2 comments · Fixed by dotnet/dotnet#32
Assignees
@MichaelSimons
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@omajid
Copy link
Member

omajid commented Jun 23, 2023

The files are here: https://github.com/dotnet/dotnet/tree/main/src/vstest/src/package/licenses

I am not sure if they apply to vstest code or are simply asset files (similar to https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Arcade.Sdk/tools/Licenses) that could be applied to the built nuget packages in some modes (but aren't, in source-build mode).

Reported to vstest as microsoft/vstest#4574
@dotnet-issue-labeler dotnet-issue-labeler bot added area-additional-repos Adding additional contributing repos untriaged labels Jun 23, 2023
@omajid omajid mentioned this issue Jun 23, 2023
Closed
@MichaelSimons MichaelSimons added area-upstream-fix Needs a change in a contributing repo and removed area-additional-repos Adding additional contributing repos untriaged labels Jun 29, 2023
@MichaelSimons MichaelSimons moved this from Backlog to Blocked in .NET Source Build Jun 29, 2023
@MichaelSimons MichaelSimons self-assigned this Jul 19, 2023
@MichaelSimons MichaelSimons moved this from Blocked to In Progress in .NET Source Build Jul 19, 2023
@MichaelSimons MichaelSimons mentioned this issue Jul 19, 2023
Merged
@premun premun mentioned this issue Jul 20, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Jul 20, 2023
@MichaelSimons
Copy link
Member

Re-opening as the first attempt to fix this broke the build and was reverted with dotnet/installer#17033

@MichaelSimons MichaelSimons reopened this Jul 20, 2023
@MichaelSimons MichaelSimons moved this from Done to In Progress in .NET Source Build Jul 20, 2023
@MichaelSimons MichaelSimons moved this from In Progress to Blocked in .NET Source Build Aug 15, 2023
@MichaelSimons MichaelSimons mentioned this issue Aug 17, 2023
Merged
@MichaelSimons
Copy link
Member

The licensing issues have been resolved.

@github-project-automation github-project-automation bot moved this from Blocked to Done in .NET Source Build Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-upstream-fix Needs a change in a contributing repo
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove cloaked licenses from vstest premun/dotnet
2 participants
@omajid @MichaelSimons