Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package validation fail #41199

Open
maridematte opened this issue May 28, 2024 · 1 comment
Open

Package validation fail #41199

maridematte opened this issue May 28, 2024 · 1 comment
Assignees
@ViktorHofer
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@maridematte
Copy link
Member

Describe the bug

When updating our PackageValidationBaselineVersion the build fails on package validation. However when running our build with /p:ApiCompatGenerateSuppressionFile=true to update the files as instructed, the only differece in the output is that the command deleted the comments we had on the xlm files:
image

You can see it in dotnet/msbuild#10116

Repro

  • Download MSBuild repo
  • Update the PackageValidationBaselineVersion to 17.10.4 (the new release version)
  • Run .\build.cmd -c Release -pack /p:ApiCompatGenerateSuppressionFile=true from msbuild repo source.
  • Check the differences in the xml files.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels May 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ViktorHofer @maridematte