Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming scheme for properties #39310

Open
richlander opened this issue Mar 7, 2024 · 2 comments
Open

Use consistent naming scheme for properties #39310

richlander opened this issue Mar 7, 2024 · 2 comments

Comments

@richlander
Copy link
Member

Notice the inconsistent use of "enable" and to some degree "true".

<PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <RootNamespace>hello_dotnet</RootNamespace>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <InvariantGlobalization>true</InvariantGlobalization>

    <!-- Publishing properties -->
    <EnableSdkContainerSupport>true</EnableSdkContainerSupport>
    <PublishAot>true</PublishAot>
    <ContainerFamily>jammy-chiseled</ContainerFamily>
    <ContainerRepository>hello-chiseled-aot</ContainerRepository>
  </PropertyGroup>

</Project>

@baronfel

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Mar 7, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MiYanni
Copy link
Member

MiYanni commented Feb 14, 2025

@richlander @baronfel Don't multiple teams own different properties and how those properties are used? Trying to "heard the cats" on this feels like it would be difficult. Plus, some of these properties are set by tooling (like VS project system), so you'd have to do a lot of work to make things consistent here. The scope is potentially large and the teams/tooling involved is also potentially large, but the gain would be low/minimal and primarily from a user consistency standpoint only. MSBuild has no native way to enforce property rules so I don't know if this ask is realistic. Thoughts?

@MiYanni MiYanni removed the untriaged Request triage from a team member label Mar 6, 2025
@MiYanni MiYanni removed their assignment Mar 6, 2025
@MiYanni MiYanni added this to the Backlog milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants