Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenAPI omits IndexerNameAttribute #38633

Open
ericstj opened this issue Feb 8, 2024 · 0 comments
Open

GenAPI omits IndexerNameAttribute #38633

ericstj opened this issue Feb 8, 2024 · 0 comments
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Feb 8, 2024

Describe the bug

When an indexer defines a custom name with IndexerNameAttribute GenAPI is not emitting that.

In the old GenAPI we had a special case for it:
https://github.com/dotnet/arcade/blob/e9a8e07465adf515a595e2afde2ffe893e973838/src/Microsoft.Cci.Extensions/Writers/CSharp/CSDeclarationWriter.Properties.cs#L39-L50

I have filed dotnet/roslyn#72007 to see if we want SyntaxGenerator to handle this, if not we'll need to workaround here.

To Reproduce

Run GenAPI against an assembly which uses IndexerNameAttribute, for example System.Xml.ReaderWriter
https://github.com/dotnet/runtime/blob/44b37e110c196aea18acbddfcc7a95b60b2a1c50/src/libraries/System.Xml.ReaderWriter/ref/System.Xml.ReaderWriter.cs#L617-L618

Observe missing attribute.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-GenAPI untriaged Request triage from a team member labels Feb 8, 2024
@ViktorHofer ViktorHofer removed the untriaged Request triage from a team member label Mar 10, 2025
@ViktorHofer ViktorHofer added this to the Backlog milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants