-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show welcome message when --getProperty
was passed
#38444
Comments
This will be more difficult to do than folks expect - the SDK's understanding of MSBuild properties (like -getProperty) is limited, and the MSBuild parsing logic happens much further along than the welcome message. We'd have to do some serious reshuffling. More broadly we have requests to look at how the SDK can spew text to stdout, and we think the more comprehensive approach would be to make out-of-band information like the welcome message write to stderr instead of stdout. This will require some finess, though, because until recently Powershell interpreted anything written to stderr as an actual error. |
Also, environment variable |
Yeah, if that's the case, it will fail CI job |
If welcome message is SDK's thing and not a |
Update:
Next, we decided to try running some dotnet command which will trigger welcome message first (in
So, in other words, commands which I expect to display welcome message are not showing it, and commands which I expect to do the job do show the welcome message. Edit:
A lot of unwanted text in the log though. |
When a user executes
dotnet build
command with--getProperty
, for example:Most likely that it's output is gonna be parsed.
However in some cases (or every time in CI, in clean docker environment) the welcome message is being prepended to the output, which breaks parsing.
I've seen #3828 and dotnet/cli#13275 but it seems to me in this case it's clear that user never wants a welcome message, so can you consider never showing welcome message if
--getProperty
was passed?Also, bonus suggestion, may be everyone will benefit if welcome message is only displayed when
dotnet
(ordotnet build
in case welcome message is tied only with build command) is executed with no arguments?The text was updated successfully, but these errors were encountered: