[workloads] The sdk added exclusions to to workload manifests that were in active use

[lewing]

As part of dealing with issues due to manifest renaming around net7 rc1 the sdk explicitly banned workload manifest names that were still in active use in main and no sdk/installer tests identified that this situation made the .NET8 wasm-tools workload uninstallable. At a bare minimum the ban list tests should verify that no banned workload name in the sdk is still in active use as a bundled workload in dotnet/installer

[lewing]

This made dotnet/runtime#80401 a requirement for preview1

[marcpopMSFT]

The list is here: https://github.com/dotnet/sdk/blob/main/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs#L18

@lewing I'm not 100% sure of the ask in this issue. I think you want us to verify that the exclusion list doesn't include an item in the known workload list. Are you interested in bringing back the workload name without .current (ie should we just remove that from the exclusion list for 8)?

[lewing]

net6.0 is still using that mono.toolchain name, and now VS isn't loading the workload for net6.0

The thing I was referring to is https://github.com/dotnet/sdk/blob/main/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs#L25

[lewing]

This appears to be the cause of mono/SkiaSharp#2640

[lewing]

I have verified that manually renaming the workload directory inside the sdk causes it to function correctly

[lewing]

The list is here: https://github.com/dotnet/sdk/blob/main/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs#L18

@lewing I'm not 100% sure of the ask in this issue. I think you want us to verify that the exclusion list doesn't include an item in the known workload list. Are you interested in bringing back the workload name without .current (ie should we just remove that from the exclusion list for 8)?

Beyond not doing this sort of thing again without a heads up, we could avoid the customer issue by making the outdated list apply by tfm if we have that information available at this point in the resolution.