PrivateAsset PackageReferences causing framework dependencies to be dropped from the publish operation

[jackj-msft]

Steps to Repro

1. Create a new .NET Core 3.1 console application.
2. Publish a self-contained application.
3. This will result in version 4.7.1 of System.Runtime.CompilerServices.Unsafe to appear in the publish directory
4. Add the NuGet reference

<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.9.0">
    <PrivateAssets>All</PrivateAssets>
</PackageReference>

5. Repeat step number 2 and publish another self-contained application

Expected
6. Version 4.7.1 of System.Runtime.CompilerServices.Unsafe exists in the publish directory.

Actual
6. System.Runtime.CompilerServices.Unsafe is missing from the publish directory.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[wli3]

PrivateAssets should only control what compiler sees. It should not affect the output of the build. @nkolev92 any idea on this issue?

[nkolev92]

It should not affect the output of the build. @nkolev92 any idea on this issue?

I think the publish flows looks at PrivateAssets incorrectly. Unfortunately changing that right now is a breaking change.

I was able to find this dup issue on sdk side, #1019

[jackj-msft]

Is the workaround for now to not have "PrivateAssets" in our projects?
Is this due to be fixed in the .NET 6 time frame?

[marcpopMSFT]

We'll track as #1019 so closing this. No plans to resolve this for now.

[dsplaisted]

The workaround is to also specify Publish="true", for example:

<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.9.0">
    <PrivateAssets>All</PrivateAssets>
    <Publish>true</Publish>
</PackageReference>

More details here: #1019 (comment)