Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perf of creating modified apphost #1339

Closed
steveharter opened this issue Jun 13, 2017 · 1 comment
Closed

Improve perf of creating modified apphost #1339

steveharter opened this issue Jun 13, 2017 · 1 comment
Assignees
Milestone

Comments

@steveharter
Copy link
Member

When the modified apphost file is created for standalone apps, it first is a copy of the original apphost file and then the entire contents are replaced instead of just the specific section(s) necessary. This is inefficient; the file size is currently around 77K.

The code should be changed to use a stream approach and just replace the specific sections that actually change (only the hash values change).

This was prioritized due to changes in #1338.

@nguerrera
Copy link
Contributor

We also read the whole file in to a managed byte array, which shouldn't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants