Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NET.Sdk package produced from official build bundling outdated NuGet #10759

Closed
jkoritzinsky opened this issue Mar 3, 2020 · 2 comments

Comments

@jkoritzinsky
Copy link
Member

According to BAR, the most recent build from dotnet/sdk should include a build from NuGet/NuGet.Client at
NuGet/NuGet.Client@64f2feb, however, by downloading the package from the build at https://dev.azure.com/dnceng/internal/_build/results?buildId=543706 and inspecting the versions of NuGet in the Microsoft.NET.Sdk package, it looks like it bundles a copy of NuGet from commit NuGet/NuGet.Client@cb402b5.

My guess would be that the bug is because in eng/Versions.props the line that Darc updates

<NuGetBuildTasksPackageVersion>5.6.0-preview.1.6478</NuGetBuildTasksPackageVersion>

is overridden by

sdk/eng/Versions.props

Lines 43 to 57 in 1f2a4a1

<PropertyGroup>
<!-- Dependencies from https://github.com/nuget/nuget.client -->
<NuGetBuildTasksPackageVersion>5.5.0-preview.2.6355</NuGetBuildTasksPackageVersion>
<NuGetBuildTasksPackPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetBuildTasksPackPackageVersion>
<NuGetCommandLineXPlatPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetCommandLineXPlatPackageVersion>
<NuGetProjectModelPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetProjectModelPackageVersion>
<MicrosoftBuildNuGetSdkResolverPackageVersion>$(NuGetBuildTasksPackageVersion)</MicrosoftBuildNuGetSdkResolverPackageVersion>
<NuGetCommonPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetCommonPackageVersion>
<NuGetConfigurationPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetConfigurationPackageVersion>
<NuGetFrameworksPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetFrameworksPackageVersion>
<NuGetPackagingPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetPackagingPackageVersion>
<NuGetVersioningPackageVersion>$(NuGetBuildTasksPackageVersion)</NuGetVersioningPackageVersion>
<NuGetPackagingVersion>$(NuGetPackagingPackageVersion)</NuGetPackagingVersion>
<NuGetProjectModelVersion>$(NuGetProjectModelPackageVersion)</NuGetProjectModelVersion>
</PropertyGroup>

and as a result, the NuGet version is pinned to an older version. This is blocking dotnet/runtime from uptaking a NuGet fix to prevent spurious CI failures.

cc: @ViktorHofer

@dwilsonbst
Copy link

Hello, is there any ETA for this? Running into the original issue fixed on the nuget side.

@ViktorHofer
Copy link
Member

This was fixed with #10760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants