Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Attempt at using newer image to allow H/3 Windows stress #82226

Merged
merged 3 commits into from
Feb 24, 2023
Merged

[HTTP/3] Attempt at using newer image to allow H/3 Windows stress #82226

merged 3 commits into from
Feb 24, 2023

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Feb 16, 2023 •
edited
Loading

Fixes #82258

@ManickaP ManickaP added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Feb 16, 2023
@ghost ghost assigned ManickaP Feb 16, 2023
@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP

Author: ManickaP
Assignees: ManickaP
Labels:

NO-MERGE, NO-REVIEW, area-System.Net.Http
Milestone: -

@ManickaP ManickaP force-pushed the mapichov/http3-stress-windows branch from ccff497 to 8cc838f Compare February 16, 2023 12:43
This was referenced Feb 16, 2023
Closed
Closed
@ManickaP ManickaP force-pushed the mapichov/http3-stress-windows branch 4 times, most recently from 27ed42f to bc7da0e Compare February 22, 2023 15:37
@ManickaP ManickaP force-pushed the mapichov/http3-stress-windows branch from bc7da0e to 35c8d63 Compare February 23, 2023 09:58
@ManickaP ManickaP mentioned this pull request Feb 24, 2023
Closed
@ManickaP
Copy link
Member Author

Windows H/3 stress is now running 🎉

The failure seems to be present before this change, see #82528

@antonfirsov Do you think we could merge this and solve that failure separately since it seems to be unrelated?

@ManickaP ManickaP removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Feb 24, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@ManickaP
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@dotnet dotnet deleted a comment from antonfirsov Feb 24, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@dotnet dotnet deleted a comment from antonfirsov Feb 24, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 24, 2023
@ManickaP ManickaP marked this pull request as ready for review February 24, 2023 08:31
@build-analysis build-analysis bot mentioned this pull request Feb 24, 2023
Open
5 tasks
CarnaViire
CarnaViire approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mana! :shipit:

antonfirsov
antonfirsov approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could merge this and solve that failure separately since it seems to be unrelated?

Makes sense to me, let's :shipit:!

@ManickaP ManickaP merged commit 9281022 into dotnet:main Feb 24, 2023
@ManickaP ManickaP deleted the mapichov/http3-stress-windows branch February 24, 2023 15:17
@build-analysis build-analysis bot mentioned this pull request Feb 24, 2023
Closed
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarnaViire CarnaViire CarnaViire approved these changes

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Http
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enable HTTP/3 stress on Windows
4 participants
@ManickaP @CarnaViire @antonfirsov @karelz