Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue correct Enable/Disable commands for EventSources with EventPipe #81867

Merged
merged 15 commits into from
Mar 3, 2023
Merged

Issue correct Enable/Disable commands for EventSources with EventPipe #81867

merged 15 commits into from
Mar 3, 2023

Commits on Mar 3, 2023

  1. Fix eventpipe enable/disable callbacks to match etw

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    024f2c9 View commit details
    Browse the repository at this point in the history

  2. Add test

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    39130ab View commit details
    Browse the repository at this point in the history

  3. Add comments

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    d5210cf View commit details
    Browse the repository at this point in the history

  4. Change byte to uint8_t

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    b515f97 View commit details
    Browse the repository at this point in the history

  5. Add pragma back

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    00bfd3e View commit details
    Browse the repository at this point in the history

  6. Code review feedback around session enable

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6b6e226 View commit details
    Browse the repository at this point in the history

  7. Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tr… 

    …acing/EventProvider.cs

Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
    @davmason @noahfalk
    davmason and noahfalk committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    504ff99 View commit details
    Browse the repository at this point in the history

  8. Code review feedback: variable renames, moving comments, other simple… 

    … stuff f
    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    17d0d53 View commit details
    Browse the repository at this point in the history

  9. Remove unused etwSessionId, rename EnableCallback to ProviderCallback… 

    …, and fix session_id
    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    dcee36d View commit details
    Browse the repository at this point in the history

  10. Update EventSource.cs

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    640c89d View commit details
    Browse the repository at this point in the history

  11. Disable test in wasm

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    fcacaff View commit details
    Browse the repository at this point in the history

  12. Add back sessionsChanged.Count == 0 logic

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    fe72103 View commit details
    Browse the repository at this point in the history

  13. Update EventProvider.cs

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    353c875 View commit details
    Browse the repository at this point in the history

  14. Update enabledisable.cs

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    ab6a3bb View commit details
    Browse the repository at this point in the history

  15. Update enabledisable.cs

    @davmason
    davmason committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    c76a33c View commit details
    Browse the repository at this point in the history