Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emsdk manifest dependency name to Microsoft.NET.Workload.Emscr… #81235

Closed
wants to merge 3 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Jan 26, 2023

…ipten.Current.Manifest-8.0.100-preview1

.. and updated the version with darc from channel ".NET 8".

…ipten.Current.Manifest-8.0.100-preview1

.. and updated the version with darc from channel `".NET 8"`.
@radical radical added arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools labels Jan 26, 2023
@ghost ghost assigned radical Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

…ipten.Current.Manifest-8.0.100-preview1

.. and updated the version with darc from channel ".NET 8".

Author: radical
Assignees: -
Labels:

arch-wasm, area-workloads

Milestone: -

@radical
Copy link
Member Author

radical commented Jan 26, 2023

Should this instead go in #80401?

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update Versions.props with the new property name too

@steveisok
Copy link
Member

Should this instead go in #80401?

Yeah, because we can get everything we need in one PR.

@radical
Copy link
Member Author

radical commented Jan 26, 2023

Closing to merge the changes in to #80401 .

@lewing
Copy link
Member

lewing commented Jan 26, 2023

@marcpopMSFT @dsplaisted this is going to be painful to update

@marcpopMSFT
Copy link
Member

@marcpopMSFT @dsplaisted this is going to be painful to update

@lewing what's going to be the painful part and how can we help?

@lewing
Copy link
Member

lewing commented Jan 26, 2023

@marcpopMSFT that because the preview name is now in the package name we will have to manually update the darc subscription every preview

@lewing
Copy link
Member

lewing commented Jan 26, 2023

and it looks like the sdk is only looking in its band so it is looking in alpha not preview which means the new manifests won't get picked up until the sdk updates branding and we we update the darc flow etc. which will happen alpha->preview->rc->rtm etc.

cc @mmitche

@radical
Copy link
Member Author

radical commented Jan 27, 2023

Closing in favor of #80401 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants