Turn off reloc generation for handles #60721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to dotnet#60712 we cannot unconditionally generate lea for handles, since the runtime does not expect us to generate ask for reloc hints for arbitrary constants. In addition, for many Intel CPUs it looks like rip-relative lea has greater latency than mov with an 8-byte immediate. Instead of reverting the change I'm just turning it off here, since the change also unified a couple of functions to simplify the handling. Fix dotnet#60627 Fix dotnet#60626
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsDue to #60712 we cannot unconditionally generate lea for handles, since Instead of reverting the change I'm just turning it off here, since the
|
|
cc @dotnet/jit-contrib. ASM diffs are the opposite of #60228 (comment). |
|
The test failures look to be preexisting. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #60712 we cannot unconditionally generate lea for handles, since
the runtime does not expect us to ask for reloc hints for
arbitrary constants. In addition, for many Intel CPUs it looks like
rip-relative lea has greater latency than mov with an 8-byte immediate.
Instead of reverting the change I'm just turning it off here, since the
change also unified a couple of functions to simplify the handling.
Fix #60626
Fix #60627
Fix #60629