Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial PDB / PerfMap support in Crossgen2 + System.Private.CoreLib switchover to use Crossgen2 #47019

Merged
merged 9 commits into from
Jan 16, 2021
Merged

Initial PDB / PerfMap support in Crossgen2 + System.Private.CoreLib switchover to use Crossgen2 #47019

merged 9 commits into from
Jan 16, 2021

Commits on Jan 15, 2021

  1. Move R2RDump PDB writer code to a separate assembly 

    I have moved the PDB writer code to a new assembly
ILCompiler.Diagnostics so that it can be reused by Crossgen2.
I have also added an initial trivial implementation of the
PerfMap writer.

Thanks

Tomas
    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    573af64 View commit details
    Browse the repository at this point in the history

  2. Initial changes for PDB generation support in Crossgen2

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ec2e67a View commit details
    Browse the repository at this point in the history

  3. Crossgen2 implementation of PDB / Perfmap generator

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    20448fc View commit details
    Browse the repository at this point in the history

  4. R2RTest / test build support for PDB production

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a77ab4c View commit details
    Browse the repository at this point in the history

  5. Typo in perfmap option, superfluous semicolon spotted by Manish

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    6f17421 View commit details
    Browse the repository at this point in the history

  6. Better align parameters for PDB / PerfMap generation

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    40164e0 View commit details
    Browse the repository at this point in the history

  7. Add previously missing project properties to ILCompiler.Diagnostics.c… 

    …sproj
    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    20f7ba0 View commit details
    Browse the repository at this point in the history

  8. Addressing Simon's PR feedback, msbuild project fixes for x86 

    Based on Simon's suggestion I moved the PDB / PerfMap-specific code
to a new file SymbolFileBuilder as I concur that its squatting in
the MapFileBuilder was somewhat hacky. Both classes use a new helper
class ObjectInfoBuilder that collects the information common to
both - I was reluctant to make it a base class of the *FileBuilder's
as we'd have to collect all the elements twice.

Thanks

Tomas
    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ff15684 View commit details
    Browse the repository at this point in the history

  9. Rename ObjectItem/Node/InfoBuilder to Output* to fix ambiguity

    @trylek
    trylek committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e6ee7b0 View commit details
    Browse the repository at this point in the history