-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Improve how EnumBuilder handles type attributes #33389
[mono] Improve how EnumBuilder handles type attributes #33389
Conversation
This should allow you to re-enable some tests, right? |
The pending |
This contributes to #2389 and should allow us to enable runtime/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs Lines 19 to 35 in b74422f
|
…asses Follow CoreCLR's example and add the RTSpecialName type attribute to any class field with the 'value__' name when , used as the value store for enumeration class instances. Second part of the "RTSpecialName fix" that started with dotnet#33389 - before, our behavior was to add the RTSpecialName immediately, as soon as the EnumBuilder was constructed. Contributes to dotnet#2389
…asses Follow CoreCLR's example and add the RTSpecialName type attribute to any class field with the 'value__' name when , used as the value store for enumeration class instances. Second part of the "RTSpecialName fix" that started with dotnet/runtime#33389 - before, our behavior was to add the RTSpecialName immediately, as soon as the EnumBuilder was constructed. Contributes to dotnet/runtime#2389
…asses (#34212) Follow CoreCLR's example and add the RTSpecialName type attribute to any class field with the 'value__' name when , used as the value store for enumeration class instances. Second part of the "RTSpecialName fix" that started with #33389 - before, our behavior was to add the RTSpecialName immediately, as soon as the EnumBuilder was constructed. Contributes to #2389
#19349) …asses Follow CoreCLR's example and add the RTSpecialName type attribute to any class field with the 'value__' name when , used as the value store for enumeration class instances. Second part of the "RTSpecialName fix" that started with dotnet/runtime#33389 - before, our behavior was to add the RTSpecialName immediately, as soon as the EnumBuilder was constructed. Contributes to dotnet/runtime#2389 Co-authored-by: alexischr <alexischr@users.noreply.github.com>
Literally copy set of attributes from
runtime/src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs
Line 330 in dc62dd6
contributes to #2389