Disable constantly failing NetworkInformation test #32176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Feb 12, 2020
safern
reviewed
Feb 12, 2020
| @@ -53,6 +53,7 @@ public void BasicTest_AccessInstanceProperties_NoExceptions() | |||
|
|
|||
| [Fact] | |||
| [PlatformSpecific(TestPlatforms.Linux)] // Some APIs are not supported on Linux | |||
| [ActiveIssue(18090)] | |||
There was a problem hiding this comment.
Nit: I believe we should be putting the full URL, @stephentoub changed all previous issues to do that as you can just CTRL+Click from the IDE.
There was a problem hiding this comment.
Should we then remove the int constructor from ActiveIssueAttribute?
There was a problem hiding this comment.
I think that's a good idea. Are any other repos using it?
There was a problem hiding this comment.
I believe I was going to do that and completely forgot about it. Will put up a PR now.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed in the last few rolling builds at least: #18090.
cc @dotnet/ncl