Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify signature context management in Crossgen2 #32158

Merged
merged 1 commit into from
Feb 12, 2020

Commits on Feb 12, 2020

  1. Simplify signature context management in Crossgen2

    Based on my recent design discussions with JanK it turns out that
    we don't want heterogeneous import cells in composite R2R images.
    An interesting corollary of this fact is that the signature context
    only changes internally during recursive descent into generic
    signatures and at the top level it's a singleton during the entire
    build. Due to this fact we don't need to store it in the various
    import nodes and keys and we can just use the singleton in
    NodeFactory. I have highlighted this fact by renaming it from
    InputModuleContext to SignatureContext.
    
    Thanks
    
    Tomas
    trylek committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    6a44c1f View commit details
    Browse the repository at this point in the history