-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Display stack trace at stack overflow (#31956)" #32153
Conversation
This reverts commit 65587ba.
How did you trace it down? I was trying to reproduce and debug this locally, with not much success. |
Weird, there is a one line change in the HandleHardwareException for the non-stack overflow path that somehow leaked there from my initial experiments that should not be there and I have no idea what it was supposed to do. That could possibly cause the problem. I'll try to repro the issue locally tomorrow and then see if removing it fixes the problem. |
Or, would it make sense to not to merge this revert and let me supply a fix early tomorrow instead? |
I looked at the history of changes under the coreclr directory and the first failed build with these failures and then backtracked the commits close to that build. Then started reverting locally until no repro. |
@jkotas I used this history pane on the test failures to backtrack to the first failing build: |
I'm OK with that, however, we try to fix the breaks quick as these is bringing our pass rate on CI council down, we were up 20% already on rolling builds, so it would be nice to have this in and probably you can revert this revert and include your fix? |
I am pretty hardcore about using reverts to get the CI fixed ASAP. This crash affected many PRs today. |
Yeah I agree. Plus it affects our CI reliability in telemetry, and it causes pain to people, searching for known issues and linking to those issues, etc. When this is merged, this commit can be reverted and just include an extra commit with the fix. |
This introduced test failures in System.Threading.Tasks:
https://helix.dot.net/api/2019-06-17/jobs/18d7114b-44f4-4b9e-90b5-9ea25e89b4a3/workitems/System.Threading.Tasks.Tests/console
Fixes: #32126
cc: @janvorli @jkotas