Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent crash in comhost tests #31830

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Intermittent crash in comhost tests #31830

merged 1 commit into from
Feb 6, 2020

Conversation

elinor-fung
Copy link
Member

Found another way the nativehost tests could crash from thread local variables being initialized during exit.

See #2320 and #31762

vitek-karas
vitek-karas approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm liking C# a bit more with every fix like this...

@stephentoub stephentoub merged commit a6c2851 into dotnet:master Feb 6, 2020
@elinor-fung elinor-fung deleted the nativeHostThreadLocals branch February 6, 2020 18:19
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees
No one assigned
Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @vitek-karas @stephentoub