Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to preview branding #31744

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Update to preview branding #31744

merged 1 commit into from
Feb 12, 2020

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Feb 4, 2020

No description provided.

@jaredpar
Copy link
Member

jaredpar commented Feb 4, 2020

@dagood

Looks like one of the hosting tests are failing here and this is just a branding change: Microsoft.DotNet.CoreSetup.Test.HostActivation.NativeHosting.Comhost.ActivateClass. I searched through our CI logs and don't see this failing in any other runs. Is this a real failure or possibly a flaky test?

@dagood
Copy link
Member

dagood commented Feb 4, 2020

@jaredpar looks like a repro of #2320.

Full text of this instance: https://gist.github.com/dagood/936cfbe21fe15498c483e080c298258e

@jaredpar
Copy link
Member

jaredpar commented Feb 5, 2020

@dagood yeah that looks like it. Seems like it's been failing a couple other times recently

Builds

Build Test Failure Count
#507224 1
#507225 1

Looks like @elinor-fung has a fix for it out though.

@mmitche
Copy link
Member Author

mmitche commented Feb 11, 2020

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mmitche mmitche closed this Feb 11, 2020
@mmitche mmitche reopened this Feb 11, 2020
@mmitche
Copy link
Member Author

mmitche commented Feb 11, 2020

@jaredpar Any progress on the failures here? This needs to be done pretty soon.

@jaredpar
Copy link
Member

@mmitche believe the test failures are fixed by #32153.

We should re-queue to check.

@jaredpar jaredpar closed this Feb 12, 2020
@jaredpar jaredpar reopened this Feb 12, 2020
@mmitche
Copy link
Member Author

mmitche commented Feb 12, 2020

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jaredpar
Copy link
Member

Failures in this PR are covered in #32179. Merging.

@jaredpar jaredpar merged commit 1d20606 into master Feb 12, 2020
@dagood dagood deleted the mmitche-patch-1 branch February 12, 2020 18:36
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants