[QUIC] Fixed some tests leaking unobserved exceptions #104444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
force-pushed
the
quic-unobserved-ex
branch
from
8df8d22
to
a90fa47
Compare
|
Tagging subscribers to this area: @dotnet/ncl |
campersau
reviewed
Jul 4, 2024
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs
Outdated
Show resolved
Hide resolved
MihaZupan
approved these changes
Jul 4, 2024
| @@ -62,11 +63,14 @@ public void NoSupportedCiphers_ThrowsArgumentException(TlsCipherSuite[] ciphers) | |||
| return ValueTask.FromResult(serverOptions); | |||
| } | |||
| }; | |||
| Assert.ThrowsAsync<ArgumentException>(async () => await CreateQuicListener(listenerOptions)); | |||
| await using var listener = await CreateQuicListener(listenerOptions); | |||
There was a problem hiding this comment.
How come this was supposed to be throwing before?
There was a problem hiding this comment.
it is possible it was never throwing and the test was wrong, the Tasks were not awaited in this test at all before this PR
There was a problem hiding this comment.
Looking at this again, the QuicListener creation should not throw, because we don't check the CipherSuitesPolicy there, we only access it when we get an incoming connection.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestCollection.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 4, 2024
Open
rzikm
reviewed
Jul 8, 2024
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs
Outdated
Show resolved
Hide resolved
ManickaP
force-pushed
the
quic-unobserved-ex
branch
from
ab8584e
to
546f421
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes leaking unobserved exceptions from S.N.Quic tests.
Adds print out for the leaking exceptions - I can remove it if it's considered spam.
The remaining issue comes from
QuicConnection._connectionCloseTcsbut the fix is a bit more involved, I'll do it in separate PR.Contributes to #80111