-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT ARM64-SVE: Move SVE helpers to emitarm64sve.cpp #100034
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also move the functionality of following methods as well?
emitInsSanity()
-> emitInsSveSanity()emitDispInsHelp()
-> emitDispInsSveHelp()getInsExecutionChararistics()
-getSveInsExecutionChararistics()
@kunalspathak sure thing. Since that will require me to create new SVE methods, would you prefer I do that here, or in a follow-up PR? |
sounds good. |
This change moves most (all?) SVE-specific helper methods and data structures from
emitarm64.cpp
toemitarm64sve.cpp
, and renames a few of these helpers to make it clear they are specific to SVE/SVE2. Also, I opportunistically deleted some unused methods. The hex output of the SVE unit tests is unchanged.cc @dotnet/arm64-contrib (sorry for the large PR)