Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT ARM64-SVE: Move SVE helpers to emitarm64sve.cpp #100034

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

amanasifkhalid
Copy link
Member

This change moves most (all?) SVE-specific helper methods and data structures from emitarm64.cpp to emitarm64sve.cpp, and renames a few of these helpers to make it clear they are specific to SVE/SVE2. Also, I opportunistically deleted some unused methods. The hex output of the SVE unit tests is unchanged.

cc @dotnet/arm64-contrib (sorry for the large PR)

@amanasifkhalid amanasifkhalid added the arm-sve Work related to arm64 SVE/SVE2 support label Mar 20, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move the functionality of following methods as well?

  • emitInsSanity() -> emitInsSveSanity()
  • emitDispInsHelp() -> emitDispInsSveHelp()
  • getInsExecutionChararistics() - getSveInsExecutionChararistics()

@amanasifkhalid
Copy link
Member Author

@kunalspathak sure thing. Since that will require me to create new SVE methods, would you prefer I do that here, or in a follow-up PR?

@kunalspathak
Copy link
Member

@kunalspathak sure thing. Since that will require me to create new SVE methods, would you prefer I do that here, or in a follow-up PR?

sounds good.

@amanasifkhalid
Copy link
Member Author

No diffs.

@amanasifkhalid amanasifkhalid merged commit ed0c687 into dotnet:main Mar 20, 2024
97 of 110 checks passed
@amanasifkhalid amanasifkhalid deleted the sve-helpers branch March 20, 2024 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants