Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Makefile for runtime build is broken #98210

Open
ilonatommy opened this issue Feb 9, 2024 · 2 comments
Open

[wasm] Makefile for runtime build is broken #98210

ilonatommy opened this issue Feb 9, 2024 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone

Comments

@ilonatommy
Copy link
Member

Description

Building WBT with makefile stopped working correctly. Connected discussion: #98083 (comment)

Reproduction Steps

Run WBT using makefile:
make -C src/mono/browser run-build-tests

Expected behavior

Build and run the tests with success.

Actual behavior

Request to build "clr" subset that is normally not needed:

  ** Building runtime pack for multithread **
        
  Determining projects to restore...
  Restored /home/kate/Projects/dotnet-runtime-wasm/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj (in 885 ms).
  Microsoft.NETCore.App.Runtime -> 
dotnet-runtime-wasm/eng/liveBuilds.targets(62,5): error : The CoreCLR artifacts path does not exist 'dotnet-runtime-wasm/artifacts/bin/coreclr/linux.x64.Release/'. The 'clr' subset must be built before building this project. Configuration: 'Release'. To use a different configuration, specify the 'RuntimeConfiguration' property.

Build FAILED.

dotnet-runtime-wasm/eng/liveBuilds.targets(62,5): error : The CoreCLR artifacts path does not exist 'dotnet-runtime-wasm/artifacts/bin/coreclr/linux.x64.Release/'. The 'clr' subset must be built before building this project. Configuration: 'Release'. To use a different configuration, specify the 'RuntimeConfiguration' property. 

Regression?

Yes

Known Workarounds

Build using msbuild instead:

.\build.cmd -bl /p:TargetArchitecture=wasm -subset mono+libs -c Debug 
.\dotnet.cmd build /p:TargetOS=browser /p:TargetArchitecture=wasm /p:Configuration=Debug /t:Test src/mono/wasm/Wasm.Build.Tests 

Configuration

No response

Other information

cc @kg

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Feb 9, 2024
@ghost
Copy link

ghost commented Feb 9, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Building WBT with makefile stopped working correctly. Connected discussion: #98083 (comment)

Reproduction Steps

Run WBT using makefile:
make -C src/mono/browser run-build-tests

Expected behavior

Build and run the tests with success.

Actual behavior

Request to build "clr" subset that is normally not needed:

  ** Building runtime pack for multithread **
        
  Determining projects to restore...
  Restored /home/kate/Projects/dotnet-runtime-wasm/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj (in 885 ms).
  Microsoft.NETCore.App.Runtime -> 
dotnet-runtime-wasm/eng/liveBuilds.targets(62,5): error : The CoreCLR artifacts path does not exist 'dotnet-runtime-wasm/artifacts/bin/coreclr/linux.x64.Release/'. The 'clr' subset must be built before building this project. Configuration: 'Release'. To use a different configuration, specify the 'RuntimeConfiguration' property.

Build FAILED.

dotnet-runtime-wasm/eng/liveBuilds.targets(62,5): error : The CoreCLR artifacts path does not exist 'dotnet-runtime-wasm/artifacts/bin/coreclr/linux.x64.Release/'. The 'clr' subset must be built before building this project. Configuration: 'Release'. To use a different configuration, specify the 'RuntimeConfiguration' property. 

Regression?

Yes

Known Workarounds

Build using msbuild instead:

.\build.cmd -bl /p:TargetArchitecture=wasm -subset mono+libs -c Debug 
.\dotnet.cmd build /p:TargetOS=browser /p:TargetArchitecture=wasm /p:Configuration=Debug /t:Test src/mono/wasm/Wasm.Build.Tests 

Configuration

No response

Other information

cc @kg

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 9, 2024
@kg
Copy link
Contributor

kg commented Feb 9, 2024

The src/mono/browser build-packages target still works, which is good. I will note that the run-build-tests target also demands you manually build MonoAOTCross, and I couldn't find a way to do that.

@lewing lewing added this to the Future milestone May 2, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

No branches or pull requests

3 participants